feat: enable smart account chain switching between zk/non-zk

[joaquim-verges]

Problem solved

Fixes CNCT-2148
Fixes #5224

---

PR-Codex overview

This PR introduces a patch for thirdweb to enhance smart accounts by allowing them to switch between zk and non-zk chains. It modifies the isZkSyncChain function and updates the smartWallet function to incorporate this new chain-switching capability.

Detailed summary

• Added a patch note for thirdweb to allow chain switching.
• Modified the isZkSyncChain function to remove the fallback to RPC checks.
• Updated the smartWallet function to first check if the new chain is a zkSync chain before checking if the factory contract is deployed.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2024 9:14am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2024 9:14am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2024 9:14am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2024 9:14am

[changeset-bot]

🦋 Changeset detected

Latest commit: b14c460

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
thirdweb	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[joaquim-verges]

• feat: enable smart account chain switching between zk/non-zk #5250 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite

[linear]

CNCT-2148 Can't switch between zk and non zk chains for smart wallets

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	43 KB (0%)	861 ms (0%)	4.5 s (+46.04% 🔺)	5.3 s
thirdweb (cjs)	102.91 KB (0%)	2.1 s (0%)	7.3 s (+16.9% 🔺)	9.3 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	122 ms (-18.39% 🔽)	218 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	81 ms (+83.5% 🔺)	91 ms
thirdweb/react (minimal + tree-shaking)	16.98 KB (-2.33% 🔽)	340 ms (-2.33% 🔽)	450 ms (-43.32% 🔽)	789 ms

[codecov]

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.36%. Comparing base (7791a99) to head (b14c460).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ackages/thirdweb/src/wallets/smart/smart-wallet.ts	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5250      +/-   ##
==========================================
- Coverage   45.43%   45.36%   -0.07%     
==========================================
  Files        1067     1067              
  Lines       55435    55434       -1     
  Branches     4019     3991      -28     
==========================================
- Hits        25185    25147      -38     
- Misses      29558    29596      +38     
+ Partials      692      691       -1     

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.68% <ø> (ø)		Carriedforward from 7791a99
packages	40.40% <94.44%> (-0.09%)	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...thirdweb/src/utils/any-evm/zksync/isZkSyncChain.ts	90.00% <100.00%> (+9.23%)	⬆️
...ackages/thirdweb/src/wallets/smart/smart-wallet.ts	77.00% <94.11%> (+1.21%)	⬆️

... and 2 files with indirect coverage changes