Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to switch smart wallet network to ZKsync chain #5224

Closed
alecananian opened this issue Oct 29, 2024 · 2 comments · Fixed by #5250
Closed

unable to switch smart wallet network to ZKsync chain #5224

alecananian opened this issue Oct 29, 2024 · 2 comments · Fixed by #5250

Comments

@alecananian
Copy link
Contributor

Steps to reproduce:

  • Connect a smart wallet to an EVM chain like Arbitrum Sepolia
  • Switch chains to a ZKsync chain like Treasure Topaz

The smart wallet's switchChain function fails due to no factory contract deployed on-chain, which is not applicable for ZKsync chains: https://github.com/thirdweb-dev/js/blob/main/packages/thirdweb/src/wallets/smart/smart-wallet.ts#L206
@joaquim-verges
Copy link
Member

good catch - fixing

@joaquim-verges joaquim-verges mentioned this issue Oct 31, 2024
Merged
@joaquim-verges
Copy link
Member

Fixed in #5250

@alecananian note that when switching between a zk and non zk chain, the smart wallet will change: in zk chains it will be the admin EOA address (due to native AA), on non zk chains, it will be the smart contract wallet address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable smart account chain switching between zk/non-zk thirdweb-dev/js
2 participants
@alecananian @joaquim-verges