Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect link in zh-CN and kr README.md #238

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Fix incorrect link in zh-CN and kr README.md #238

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
684409e
Fix incorrect link in zh-CN README.md
win5923 Jan 31, 2024
69f1adb
Fix incorrect link in kr README.md
win5923 Jan 31, 2024
311b260
add zh_CN translations for kubernetes setup
win5923 Jan 31, 2024
6a3d5f1
Update readme.md
win5923 Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/kr/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,13 @@ docker run -d \

### Kubernetes

쿠버네티스에 이 컨테이너를 배포하는 데 필요한 모든 파일은 [k8s 폴더](k8s/)에 있습니다.
쿠버네티스에 이 컨테이너를 배포하는 데 필요한 모든 파일은 [k8s 폴더](/k8s/)에 있습니다.

[README.md](k8s/readme.md) 에 있는 지침을 따라 배포를 진행해주세요.
[README.md](/k8s/readme.md) 에 있는 지침을 따라 배포를 진행해주세요.

#### Using helm chart

[README.md](./chart/README.md) 에 있는 지침을 따라 배포를 진행해주세요.
[README.md](/chart/README.md) 에 있는 지침을 따라 배포를 진행해주세요.

### 환경 변수

Expand Down
6 changes: 3 additions & 3 deletions docs/zh-CN/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,13 @@ docker run -d \

### Kubernetes

将此容器部署到 Kubernetes 的所有文件都位于[此文件夹中](k8s/)。
将此容器部署到 Kubernetes 的所有文件都位于[此文件夹中](/k8s/)。

请按照 [此处](k8s/readme.md) 进行部署。
请按照 [此处](/readme.md) 进行部署。

#### 使用 helm 部署

请按照 [此处](./chart/README.md) 进行部署。
请按照 [此处](/chart/README.md) 进行部署。

### 环境变量

Expand Down
10 changes: 10 additions & 0 deletions k8s/readme.md
View file
Open in desktop
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of duplicating the content to translate a single sentence

Copy link
Contributor Author

@win5923 win5923 Jan 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you like to proceed?

------edit-------

Should I remove the 'zh-cn' setup?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only remove the zh-CN/kr from the k8s/readme.md file, after that, ready to merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,13 @@
* `kubectl apply -f secret.yaml`
* `kubectl apply -f service.yaml`
* `kubectl apply -f deployment.yaml`

# 在 Kubernetes 中设置 Palworld

Check failure on line 11 in k8s/readme.md

View workflow job for this annotation

GitHub Actions / Lint - Markdown

Multiple top-level headings in the same document 

k8s/readme.md:11 MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# 在 Kubernetes 中设置 Palworld"] https://github.com/DavidAnson/markdownlint/blob/v0.33.0/doc/md025.md

使用以下命令在 Kubernetes 中设置 Palworld 容器：

* `kubectl apply -f pvc.yaml`
* `kubectl apply -f configmap.yaml`
* `kubectl apply -f secret.yaml`
* `kubectl apply -f service.yaml`
* `kubectl apply -f deployment.yaml`
Loading