Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect link in zh-CN and kr README.md #238

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Fix incorrect link in zh-CN and kr README.md #238

merged 4 commits into from
Jan 31, 2024

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Jan 31, 2024

Fix incorrect link and add zh_CN translations for kubernetes setup.

k8s/readme.md Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of duplicating the content to translate a single sentence

Copy link
Contributor Author

@win5923 win5923 Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you like to proceed?

------edit-------

Should I remove the 'zh-cn' setup?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only remove the zh-CN/kr from the k8s/readme.md file, after that, ready to merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@thijsvanloef thijsvanloef added the waiting for feedback Waiting until author responds label Jan 31, 2024
@thijsvanloef thijsvanloef merged commit 711647a into thijsvanloef:main Jan 31, 2024
4 checks passed
@win5923 win5923 deleted the patch-3 branch January 31, 2024 11:38
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
Fix incorrect link in zh-CN and kr README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback Waiting until author responds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants