Makefile: Require faketime in "make dev" #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not strictly true (creating a dev env without faketime works fine) but it's useful when getting started. Signed-off-by: Jussi Kukkonen <[email protected]>
|
ah the lint failure on CI is why this was as it was. I guess we can install faketime for linting as well EDIT: I ended up avoiding "make dev" when linting |
make dev now depends on faketime which we don't need when linting Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
require-faketime-to-make-dev
branch
from
eca9dfc to
70f3018
Compare
jku
added a commit
that referenced
this pull request
Nov 28, 2024
This release contains no new tests and test results are not expected to change, except in one case: If `test_root_rotation` or `test_non_root_rotations` are marked as "Expected To Fail" because of the non-default keytype, this expectation can now be removed: these tests now use the default keytype (ecdsa). * local testing: "make dev" now checks for faketime binary to enable failing early (#240) * Failure output was improved (#239) * Tests now use default keytype whenever possible: In `practice test_non_root_rotations()` and `test_root_rotation()` switched from ed25519 to the default ecdsa key (#238) * Expected failures are now documented better (#233) Signed-off-by: Jussi Kukkonen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not strictly a true requirement (creating a dev env without faketime works fine) but it's useful when getting started.
Fixes #234
CC @loosebazooka