Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xfails info in README.md #233

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

loosebazooka
Copy link
Collaborator

No description provided.

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. I'll add a comment example in this same PR (comments are not explicitly handled in any way but they work as expected as long as the comment does not match a test name: I don't feel like I need to explain that in the README)

@jku jku merged commit 1d9f927 into theupdateframework:main Nov 22, 2024
3 checks passed
@jku
Copy link
Member

jku commented Nov 22, 2024

Merge: 22a00e8 bb89502
Author: Jussi Kukkonen <[email protected]>
Date:   Fri Nov 22 13:21:05 2024 +0200

    Merge pull request #233 from loosebazooka/patch-1
    
    undefined

No idea what "undefined" is here but ok

jku added a commit that referenced this pull request Nov 28, 2024
This release contains no new tests and test results are not expected to
change, except in one case: If `test_root_rotation` or
`test_non_root_rotations` are marked as "Expected To Fail" because of
the non-default keytype, this expectation can now be removed: these
tests now use the default keytype (ecdsa).

* local testing: "make dev" now checks for faketime binary
  to enable failing early (#240)
* Failure output was improved (#239)
* Tests now use default keytype whenever possible:
  In `practice test_non_root_rotations()` and `test_root_rotation()`
  switched from ed25519 to the default ecdsa key (#238)
* Expected failures are now documented better (#233)

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants