ngclient: Rename constructor arg

[jku]

metadata_dir matches metadata_base_url better.

This is an API break for anyone using ngclient with named arguments.

Fixes #1638

Signed-off-by: Jussi Kukkonen [email protected]

---

I've considered the other ideas mentioned in the issue but I think this is the only one that seems clearly worth the change.

[coveralls]

Pull Request Test Coverage Report for Build 1582477315

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.561%

---

Totals
Change from base Build 1582019278:	0.0%
Covered Lines:	3930
Relevant Lines:	3957

---

💛 - Coveralls

[lukpueh]

LGTM! And I agree with you, all the other ideas we discussed in #1638 seem a lot less important.