-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngclient: review argument names #1638
Comments
I did have a similar hunch. Just wanted to briefly rethink this together. But I'm fine with leaving those and don't make the names any longer. |
Since we have this issue, I'll bring up another very mild naming concern I had. When I read |
Argument names currently
possible changes:
|
metadata_dir matches metadata_base_url better. This is an API break for anyone using named arguments. Fixes theupdateframework#1638 Signed-off-by: Jussi Kukkonen <[email protected]>
Now that API seems to stabilizing (and before we have a stable release) let's check that argument names ngclient uses are consistent.
Lukas in #1604:
At least metadata vs repository seems like an obvious flaw: no need to use two different terms.
The second one I'm not so sure about: the names are long enough that I already avoid naming the args because of it, and for me "url" vs "dir" does give a hint that one is remote and one is not remote...
The text was updated successfully, but these errors were encountered: