tests: Add ngclient root key rotation tests #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jku
force-pushed
the
key-rotation-tests
branch
from
e63daf2 to
631a640
Compare
Pull Request Test Coverage Report for Build 1384520773Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jku
commented
Oct 26, 2021
tests/repository_simulator.py
Outdated
Comment on lines
143
to
146
| def add_signer(self, role:str, signer: SSlibSigner): | ||
| if role not in self.signers: | ||
| self.signers[role] = {} | ||
| self.signers[role][signer.key_dict["keyid"]] = signer |
|
I should also fix some linter issues if we're going to enable the linter on tests... |
sechkova
reviewed
Oct 27, 2021
tests/test_updater_key_rotations.py
Outdated
| # Copyright 2021, New York University and the TUF contributors | ||
| # SPDX-License-Identifier: MIT OR Apache-2.0 | ||
|
|
||
| """Test ngclient Updater using the repository simulator |
There was a problem hiding this comment.
nit: the docstring needs to be updated.
tests/test_updater_key_rotations.py
Outdated
| RootVersion([0,1,2,3,4], 3, [0,2,4]), | ||
| RootVersion([0,1,3,4,5], 3, [0,4,1]), | ||
| ], | ||
| "3-of-5, one key rotate fails: not signed with 3 keys from last root" : [ |
|
ah and yeah, I think we need to add smaller tests for other keys as well, not necessarily with this PR. |
jku
force-pushed
the
key-rotation-tests
branch
from
631a640 to
d4f839a
Compare
sechkova
approved these changes
Oct 27, 2021
added 3 commits
October 27, 2021 18:57
Store signers with their keyids so they are easier to remove.
The signers structure now looks like:
{
"role1": {
"keyidA": SSlibSigner,
"keyidB": SSlibSigner,
}
}
Add convenience method for adding a signer.
Signed-off-by: Jussi Kukkonen <[email protected]>
Signed-off-by: Jussi Kukkonen <[email protected]>
Add one test with 1 subtests for various root key rotation situations. The test data definition format is a bit tricky but I tried to document that in the test function docstring. Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
key-rotation-tests
branch
from
d4f839a to
e817473
Compare
|
The last push is just rebase on recent RepositorySimulator changes.
Not promising it's 100% there (hard to test without merging with martins PR), but most of the issues should be handled: I'll merge this with the current approval. @MVrachev if there's something exceptionally annoying when you try rebasing, let me know |
This was referenced Oct 27, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 15 key rotation cases to ngclient tests.
Maybe fixes #1607? This only tests root keys but I think this is the tricky part: maybe there should be a small test for other keys as well...