Fix Root.add_key() argument's type #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force-pushed after I changed my mind over the test case a bit |
jku
reviewed
May 13, 2021
I was wondering whether to add such tests case because the bug was in our test using incorrectly the class ... and in the type annotation but types in Python ... |
After the implementation of a Key class representing the public portion of a key, the method add_key() should take an argument of type Key, instead of a dictionary. Test cases are updated accordingly. Signed-off-by: Teodora Sechkova <[email protected]>
yeah you do have a point here -- thanks anyway. |
jku
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1378
Description of the changes being introduced by the pull request:
Since the existence of a
Keyclass, takingKeyas an argument type seems like the logical change.The test case is updated accordingly.
Since there are no "users" of this functionality yet, I can't say if further improvements are
needed for now.
Please verify and check that the pull request fulfills the following
requirements: