Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata API: Root.add_key() is broken #1378

Closed
jku opened this issue May 7, 2021 · 1 comment · Fixed by #1386
Closed

Metadata API: Root.add_key() is broken #1378

jku opened this issue May 7, 2021 · 1 comment · Fixed by #1386
Assignees
@sechkova
Labels
bug

Comments

@jku
Copy link
Member

jku commented May 7, 2021 •
edited
Loading

Recent Key object addition broke Root.add_key(): it now adds a dictionary into the internal dict but it should add a Key. This can be tested by adding a metadata.to_dict() after calling Root.add_key() in the tests.

I didn't fix it since I don't know how this is used -- should the function accept a Key as arg?
@jku jku added the bug label May 7, 2021
@jku
Copy link
Member Author

jku commented May 7, 2021

cc @MVrachev

@jku jku mentioned this issue May 11, 2021
Closed
@sechkova sechkova self-assigned this May 12, 2021
@sechkova sechkova mentioned this issue May 12, 2021
Merged
3 tasks
@jku jku closed this as completed in #1386 May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sechkova sechkova

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Root.add_key() argument's type sechkova/tuf
2 participants
@jku @sechkova