Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search page with POST and FormData examples #3

Merged
merged 27 commits into from
Sep 1, 2023
Merged

Search page with POST and FormData examples #3

merged 27 commits into from
Sep 1, 2023

Conversation

thescientist13
Copy link
Owner

@thescientist13 thescientist13 commented Aug 9, 2023 •
edited
Loading

  1. Using POST method for greeting component and FormData
  2. Create a Search page
  3. Move styles to standalone file

TODOs

  1. Something about this branch is breaking infinite scroll locally... (must be the patch?)
  2. Feature/issue 1048 handle merging additional Request / Response properties ProjectEvergreen/greenwood#1132
  3. use Request.formData method
  4. multi part form support? - see support additional Request.body formats ProjectEvergreen/greenwood#1147
  5. Needs bug/issue 1048 handle shared adapter bundles missing for API routes ProjectEvergreen/greenwood#1149
  6. clean up example code

@thescientist13 thescientist13 added the enhancement New feature or request label Aug 9, 2023
@vercel
Copy link

vercel bot commented Aug 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
greenwood-htmx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 2:28pm

@thescientist13 thescientist13 self-assigned this Aug 10, 2023
This was referenced Aug 10, 2023
Closed
Merged
@thescientist13 thescientist13 changed the title Greenwood htmx POST API htmx with POST API Aug 12, 2023
@thescientist13 thescientist13 changed the base branch from master to htmx August 12, 2023 20:14
@thescientist13 thescientist13 mentioned this pull request Aug 12, 2023
Merged
4 tasks
thescientist13
thescientist13 commented Aug 27, 2023
View reviewed changes
patches/@greenwood+cli+0.29.0-alpha.2.patch Outdated
- const response = await handler(request);
+ const { headers, body, method } = request;
+ // TODO is a double request needed here?
+ const response = await handler(new Request(new Request(href, {

This comment was marked as outdated.

Sign in to view

@thescientist13 thescientist13 changed the title htmx with POST API Search page with POST and FormData examples Aug 27, 2023
thescientist13
thescientist13 commented Aug 31, 2023
View reviewed changes
src/pages/search.html Outdated
>
<label>
Search for...
<input type="text" name="term" placeholder="an artist..." required/>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use type="search" here

@thescientist13 thescientist13 merged commit 40d3a63 into master Sep 1, 2023
@thescientist13 thescientist13 deleted the greenwood-htmx-post-api branch September 1, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13