-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle merging additional Request
/ Response
instance properties
#1048
Comments
8 tasks
thescientist13
changed the title
handle merging all
handle merging all Feb 18, 2023
Response
instance propertiesResponse
instance properties and headers
6 tasks
2 tasks
thescientist13
moved this to 🏗 In progress
in [Greenwood] Phase 9 - Standards and Conventions
Aug 2, 2023
14 tasks
thescientist13
changed the title
handle merging all
handle merging all Aug 10, 2023
Response
instance properties and headersRequest
/ Response
instance properties and headers
thescientist13
added
P0
Critical issue that should get addressed ASAP
Adapter
CLI
SSR
alpha.3
and removed
P0
Critical issue that should get addressed ASAP
labels
Aug 10, 2023
thescientist13
changed the title
handle merging all
handle merging all Aug 16, 2023
Request
/ Response
instance properties and headersRequest
/ Response
instance properties
thescientist13
changed the title
handle merging all
handle merging additional Aug 24, 2023
Request
/ Response
instance propertiesRequest
/ Response
instance properties
thescientist13
moved this from 🏗 In progress
to 👀 In review
in [Greenwood] Phase 9 - Standards and Conventions
Aug 26, 2023
Merged
25 tasks
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in [Greenwood] Phase 9 - Standards and Conventions
Aug 26, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
As part of #948, we created a utility in resource-utils.js to merge
Response
objects when needed, but it doesn't currently support anything otherbody
andheaders
.In addition, instances of
Request
are missing critical properties likebody
, which means Greenwood is totally unusable for handlingPOST
requestshttps://github.com/ProjectEvergreen/greenwood/blob/v0.28.5/packages/cli/src/lifecycles/serve.js#L37
Details
I would like to make sure that we can merge all relevant
Response
instance properties likestatus
statusText
Content-Length
And
Request
instance propertiesmethod
body
(make sure it supportsjson
,formData
, etc)Needs to be done in
The text was updated successfully, but these errors were encountered: