Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/issue 1159 devServer proxy routing broken with content encoding header #1160

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Bug/issue 1159 devServer proxy routing broken with content encoding header #1160

merged 3 commits into from
Oct 14, 2023

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 7, 2023 •
edited
Loading

Related Issue

resolves #1159

Summary of Changes

  1. Filter out content-encoding fgrom dev server proxy requests

TODO

  1. Would be nice to narrow down the regression (my guess is in handle merging additional Request / Response instance properties #1048 ?)
  2. Would be nice to get a test case to reproduce this

Somewhat related, but should we rename it to just devServer? Now that we're full stack, does it even matter? 🤔

@thescientist13 thescientist13 added bug Something isn't working CLI alpha.5 v0.29.0 labels Oct 7, 2023
@thescientist13 thescientist13 linked an issue Oct 7, 2023 that may be closed by this pull request
devServer proxy not returning content (when proxied response includes a content-encoding header) #1159
Closed
@thescientist13 thescientist13 force-pushed the bug/issue-1159-proxy-routing-broken-with-content-encoding-header branch from 31c8277 to 47cd211 Compare October 14, 2023 00:54
@thescientist13 thescientist13 merged commit 844856a into release/0.29.0 Oct 14, 2023
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1159-proxy-routing-broken-with-content-encoding-header branch October 14, 2023 01:09
thescientist13 added a commit that referenced this pull request Nov 9, 2023
@thescientist13
Bug/issue 1159 devServer proxy routing broken with content encoding h…
3c9b8ca 
…eader (#1160)

* filter out content encoding header from proxy request resource

* comment callout regarding devServer usage in non development scenarios

* add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

devServer proxy not returning content (when proxied response includes a content-encoding header)
1 participant
@thescientist13