Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CMake code on linking against required dependencies #43

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Simplify CMake code on linking against required dependencies #43

merged 2 commits into from
Oct 4, 2022

Conversation

allanleal
Copy link
Contributor

Fixes #42

@allanleal
Add nlohmann_json to ThermoFunFindDeps.
750fcb3 
Removed else branch that prints found version of dep. This is already printed by default when found.
@allanleal
Simplified target_link_library calls; only one now with all require…
258e944 
…d deps
@allanleal allanleal requested a review from gdmiron September 27, 2022 09:45
gdmiron
gdmiron approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@gdmiron gdmiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Greetings from New York.

@allanleal allanleal merged commit 8778a71 into thermohub:master Oct 4, 2022
@allanleal allanleal deleted the fix-42 branch October 4, 2022 11:44
@allanleal
Copy link
Contributor Author

Enjoy your vacation, Dan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdmiron gdmiron gdmiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing find_package for json dependency
2 participants
@allanleal @gdmiron