Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing find_package for json dependency #42

Closed
Jarnovr opened this issue Sep 23, 2022 · 0 comments · Fixed by #43
Closed

Missing find_package for json dependency #42

Jarnovr opened this issue Sep 23, 2022 · 0 comments · Fixed by #43

Comments

@Jarnovr
Copy link

Jarnovr commented Sep 23, 2022

Hi,

I'm building Thermofun 0.3.8 from sources on windows (as part of building reaktoro).
The build is failing as the source files reference nlohmann/json.hpp which they can't find.

In ThermoFun\CmakeLists.txt around line 40 there is some conditional code and on windows with visual studio nothing is done while on linux there is a dependency explicitly defined.

I added this to the MSVC section and that worked:

   find_package(nlohmann_json REQUIRED)
		 target_link_libraries(ThermoFun
         PRIVATE nlohmann_json::nlohmann_json)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant