Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotations #176

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Add annotations #176

merged 4 commits into from
Oct 26, 2021

Conversation

DavisFrench
Copy link
Contributor

Description

Switch to using annotations instead of messages
Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

aleksej-paschenko
aleksej-paschenko reviewed Oct 25, 2021
View reviewed changes
Copy link
Contributor

@aleksej-paschenko aleksej-paschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

config/crd/bases/theketch.io_apps.yaml Outdated Show resolved Hide resolved
internal/api/v1beta1/app_types.go Outdated Show resolved Hide resolved
@DavisFrench DavisFrench marked this pull request as ready for review October 25, 2021 15:47
aleksej-paschenko
aleksej-paschenko approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@aleksej-paschenko aleksej-paschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome!

@DavisFrench DavisFrench merged commit 3103217 into improve-canary-events Oct 26, 2021
@DavisFrench DavisFrench deleted the add-annotations branch October 26, 2021 13:30
DavisFrench pushed a commit that referenced this pull request Oct 26, 2021
@koncar @DavisFrench
Target fixes and change event generation
4e176f0 
Rename and move AppReconcileOutcome and add tests

Improve events

Revert unecessary change

Fix test

Fix tests

Add annotations (#176)

* Add annotations to canary events

* Fix tests, remove unneccessary code

* Create consts for annotation names

* Remove unneccessary comments and prints
DavisFrench pushed a commit that referenced this pull request Oct 26, 2021
@koncar
Target fixes and change event generation (#167)
3395f4e 
Rename and move AppReconcileOutcome and add tests

Improve events

Revert unecessary change

Fix test

Fix tests

Add annotations (#176)

* Add annotations to canary events

* Fix tests, remove unneccessary code

* Create consts for annotation names

* Remove unneccessary comments and prints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksej-paschenko aleksej-paschenko aleksej-paschenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavisFrench @aleksej-paschenko