Target fixes and change event generation #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koncar
force-pushed
the
improve-canary-events
branch
3 times, most recently
from
f456930
to
b07b6fb
Compare
koncar
force-pushed
the
improve-canary-events
branch
from
12f4a19
to
4b9a76d
Compare
|
|
||
| // Message is message for k8s event | ||
| func (c CanaryEvent) Message() string { | ||
| return fmt.Sprintf("%s - Canary for app %s | version %d - %s", c.Name, c.AppName, c.DeploymentVersion, c.Description) |
There was a problem hiding this comment.
I'd probably make "%s - Canary for app %s | version %d - %s". Not a huge concern. Same with the NextStepEvents and ChangeEvents below.
DavisFrench
reviewed
Oct 20, 2021
DavisFrench
approved these changes
Oct 20, 2021
aleksej-paschenko
requested changes
Oct 21, 2021
Rename and move AppReconcileOutcome and add tests Improve events Revert unecessary change Fix test Fix tests Add annotations (#176) * Add annotations to canary events * Fix tests, remove unneccessary code * Create consts for annotation names * Remove unneccessary comments and prints
DavisFrench
force-pushed
the
improve-canary-events
branch
from
3103217
to
4e176f0
Compare
aleksej-paschenko
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create dedicated structs for generated Canary events
Type of change
Testing
Documentation
Final Checklist: