Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make electron runtime deps optional #4873

Merged
merged 1 commit into from
Apr 11, 2019
Merged

make electron runtime deps optional #4873

merged 1 commit into from
Apr 11, 2019

Conversation

akosyakov
Copy link
Member

fix #4871
fix #2758

@akosyakov akosyakov force-pushed the GH-4871 branch 2 times, most recently from 4735232 to d4d8967 Compare April 11, 2019 07:47
@akosyakov akosyakov changed the title WIP make electron runtime deps optional make electron runtime deps optional Apr 11, 2019
@akosyakov
Copy link
Member Author

It's ready for the review. Guys please have a look we need to fix theia-apps next images.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look good to me, however, I could not try it in a final, bundled application.

@akosyakov
Copy link
Member Author

thanks @kittaakos, waiting for travis build and merging if no objections

@kittaakos
Copy link
Contributor

merging if no objections

Sure, if I understood the issue, the theia-apps are broken anyway so that it won't be worse.

@akosyakov
Copy link
Member Author

@kittaakos it will allow to fix them, i more worry about people who build electron products that we break them now :)

Copy link
Member

@thegecko thegecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosyakov akosyakov merged commit a33a2e2 into master Apr 11, 2019
@akosyakov akosyakov deleted the GH-4871 branch April 11, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

native-keymap should be optional dep Don't distribute electron
4 participants