Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native-keymap should be optional dep #4871

Closed
akosyakov opened this issue Apr 11, 2019 · 2 comments · Fixed by #4873 or #4882
Closed

native-keymap should be optional dep #4871

akosyakov opened this issue Apr 11, 2019 · 2 comments · Fixed by #4873 or #4882
Assignees
@akosyakov
Labels
bug bugs found in the application

Comments

@akosyakov
Copy link
Member

Motivated by theia-ide/theia-apps#163

All next images are broken again 🙈

cc @spoenemann
@akosyakov akosyakov added the bug bugs found in the application label Apr 11, 2019
@akosyakov akosyakov self-assigned this Apr 11, 2019
@akosyakov
Copy link
Member Author

See #2758 (comment)

@akosyakov akosyakov mentioned this issue Apr 11, 2019
Merged
@akosyakov
Copy link
Member Author

It did not work. Electron deps has to be also removed from theia-cli: https://travis-ci.org/theia-ide/theia-apps/jobs/518657324#L538

@akosyakov akosyakov reopened this Apr 11, 2019
akosyakov added a commit that referenced this issue Apr 11, 2019
@akosyakov
fix #4871: remove electron runtime dependency from CLI
0dbfbb3 
Signed-off-by: Anton Kosyakov <[email protected]>
@akosyakov akosyakov mentioned this issue Apr 11, 2019
Merged
akosyakov added a commit that referenced this issue Apr 11, 2019
@akosyakov
fix #4871: remove electron runtime dependency from CLI
4dc74a5 
Signed-off-by: Anton Kosyakov <[email protected]>
DoroNahari pushed a commit to DoroNahari/theia that referenced this issue Apr 29, 2019
@akosyakov
fix eclipse-theia#4871: remove electron runtime dependency from CLI
a6889af 
Signed-off-by: Anton Kosyakov <[email protected]>

Signed-off-by: Doron Nahari [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application
Projects
None yet
Milestone
No milestone
1 participant
@akosyakov