Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove electron runtime dependency from CLI #4882

Merged
merged 1 commit into from
Apr 11, 2019
Merged

remove electron runtime dependency from CLI #4882

merged 1 commit into from
Apr 11, 2019

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 11, 2019 •
edited
Loading

fix #4871

that's a follow up of #4873, turns out we have to remove it from CLI as well otherwise unnecessary deps pulled anyway: https://travis-ci.org/theia-ide/theia-apps/jobs/518657324#L538

kittaakos
kittaakos approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried yarn && yarn run rebuild:electron && yarn --cwd ./examples/electron/ start, the application started.

@akosyakov akosyakov merged commit 4dc74a5 into master Apr 11, 2019
@akosyakov akosyakov deleted the GH-4871 branch April 11, 2019 12:35
@akosyakov akosyakov mentioned this pull request Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

@thegecko thegecko Awaiting requested review from thegecko

@spoenemann spoenemann Awaiting requested review from spoenemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

native-keymap should be optional dep
2 participants
@akosyakov @kittaakos