Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository.py #1266

Merged
merged 3 commits into from
Jul 16, 2021
Merged

Conversation

igramic
Copy link
Contributor

@igramic igramic commented Jul 14, 2021

add support for filtering repositories by OS version based on API feature apidoc/v2/repositories/create.html

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks great, thanks!

There is a documentation suggestion inline, plus:

  • could you please make the commit message more descriptive (something like "add support for filtering repositories by OS version")?
  • could you add a changelog snippet in changelogs/fragments? it's supposed to be a .yml file with a content like this:
minor_changes:
  - repository - <explanation>
  • as far as I understand, this only works for YUM repos, so probably a good idea to add this parameter to the list in
    if module.foreman_params['content_type'] != 'yum':
    invalid_list = [key for key in ['ignorable_content'] if key in module.foreman_params]
    if invalid_list:
    module.fail_json(msg="({0}) can only be used with content_type 'yum'".format(",".join(invalid_list)))

plugins/modules/repository.py Outdated Show resolved Hide resolved
igramic and others added 2 commits July 14, 2021 15:07
@evgeni
Copy link
Member

evgeni commented Jul 14, 2021

changes look good to me, Igor wanted to do a few tests with it tomorrow, and then we can merge

@evgeni evgeni merged commit 604f60b into theforeman:develop Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants