Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arch option to theforeman.foreman.repository module #1265

Closed
igramic opened this issue Jul 14, 2021 · 10 comments · Fixed by #1282
Closed

Add arch option to theforeman.foreman.repository module #1265

igramic opened this issue Jul 14, 2021 · 10 comments · Fixed by #1282
Assignees
Labels
easy Good opportunity to start contributing enhancement triaged

Comments

@igramic
Copy link
Contributor

igramic commented Jul 14, 2021

SUMMARY

In Satellite GUI when we create product repository we can restrict that repository on specific OS version (rhel8, rhel7 ...) and architecture
It would be awesome if we could do same via theforeman.foreman.repository

ISSUE TYPE
  • Feature Idea
@evgeni
Copy link
Member

evgeni commented Jul 14, 2021

from the API doc (of 4.1):

os_versions - Identifies whether the repository should be disabled on a client with a non-matching OS version. Pass [] to enable regardless of OS version. Maximum length 1; allowed tags are: rhel-6, rhel-7, rhel-8

also interesting:

arch - Architecture of content in the repository

@evgeni
Copy link
Member

evgeni commented Jul 20, 2021

@igramic implemented the os_version in #1266 - so we're only missing arch now.

@evgeni evgeni changed the title Add restrict_os option to theforeman.foreman.repository module Add arch option to theforeman.foreman.repository module Jul 20, 2021
@evgeni evgeni added easy Good opportunity to start contributing enhancement triaged labels Aug 17, 2021
@SimonLorentz
Copy link

Hello everyone,

is there a timeline, when we can expect this new feature?
Would be very cool for a project.

Best regards

evgeni added a commit to evgeni/foreman-ansible-modules that referenced this issue Sep 7, 2021
@evgeni
Copy link
Member

evgeni commented Sep 7, 2021

@SimonLorentz as you asked so nicely, feel free to try #1282 ;-)

@SimonLorentz
Copy link

@evgeni thanks, it seems to do nothing, no error, but also no action ^^

@evgeni
Copy link
Member

evgeni commented Sep 7, 2021

Which Katello version are you running, and what would you expect to happen once you set that option?

@SimonLorentz
Copy link

I´m running against Satellite 6.9 with Katello 3.18.1.

image

I would expect, that the arch is set in my repository, like the version.

@evgeni
Copy link
Member

evgeni commented Sep 7, 2021

That parameter is only present in the Katello 4.0+ API: https://projects.theforeman.org/issues/31615

You actually should have gotten a warning from Ansible, that the parameter is not supported by your server. Something like "The following parameters are not supported by your server when performing update on repository: arch. They were ignored."

@SimonLorentz
Copy link

Ah okay yes I got it, my bad

@evgeni
Copy link
Member

evgeni commented Sep 7, 2021

FWIW, I tried this against a Katello 4.1 installation, and it works exactly as you'd expect ;)

evgeni added a commit to evgeni/foreman-ansible-modules that referenced this issue Sep 7, 2021
evgeni added a commit that referenced this issue Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Good opportunity to start contributing enhancement triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants