fixed an issue with datetimeimmutable comparaison #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kharhamel
changed the title
Kharhamel
changed the title
Kharhamel
force-pushed
the
fix/datetimeImmutable
branch
from
9e8f9cf to
efc05a2
Compare
Kharhamel
force-pushed
the
fix/datetimeImmutable
branch
2 times, most recently
from
e5e50d2 to
1dcd0e9
Compare
bendavies
reviewed
Jan 6, 2020
| $this->innerDateTime = new parent($time, $timezone); | ||
| } | ||
|
|
||
| //switch from regular datetime to safe version | ||
| private static function createFromRegular(\DateTimeImmutable $datetime): self | ||
| { | ||
| $safeDatetime = new self(); | ||
| $safeDatetime = new self($datetime->format('Y-m-d H:i:s'), $datetime->getTimezone()); //we need to also update the wrapper to not break the operators '<' and '>' |
There was a problem hiding this comment.
damn i forgot about theses
There was a problem hiding this comment.
So milliseconds can't be used with < 7.4 because ::createFromFormat doesn't accept it, microseconds should be used.
|
@Kharhamel thank you for fast response, can we potentially get a patch release with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr solves #179