Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include microseconds in Date objects #183

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Include microseconds in Date objects #183

merged 3 commits into from
Jan 9, 2020

Conversation

kunicmarko20
Copy link
Contributor

@kunicmarko20 kunicmarko20 commented Jan 8, 2020 •
edited
Loading

closes #182

@kunicmarko20 kunicmarko20 changed the title Include microseconds in Date objects Include miliseconds in Date objects Jan 8, 2020
@kunicmarko20
Copy link
Contributor Author

So milliseconds can't be used with < 7.4 because ::createFromFormat doesn't accept it, will switch to microseconds.

@kunicmarko20 kunicmarko20 changed the title Include miliseconds in Date objects Include microseconds in Date objects Jan 8, 2020
@Kharhamel Kharhamel merged commit eb13cdb into thecodingmachine:master Jan 9, 2020
@Kharhamel
Copy link
Collaborator

Kharhamel commented Jan 9, 2020 •
edited
Loading

Thanks a lot. Will release it later today

@kunicmarko20 kunicmarko20 deleted the patch-1 branch January 9, 2020 16:53
@kunicmarko20
Copy link
Contributor Author

Thank you for quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datetimeimmutable internal value doesn't use milliseconds
2 participants
@kunicmarko20 @Kharhamel