-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to make CI green #96
Conversation
Woah, so cool! Thanks a lot for this PR! |
Perfect timing, I just finished (: Do review it please, though! Some comments/questions:
|
I did review it! Really good job 👍
Definitely, it would make sense for the next minor version!
That would be awesome. But we can save that for another PR.
Let's keep it for now. There was a trick where I was uninstalling the "security bundle" and running tests again to test the behaviour of the graphqlite-bundle when there is no security bundle. We should probably reproduce that at some point. |
Several fixes:
None of this should be a breaking change
++ Some of this version bumps should go into the graphqlite package! – I can create a PR there later, but it doesn't hurt to have them here as well