Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parsing tokens on PHP 8 #114

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix parsing tokens on PHP 8 #114

merged 1 commit into from
Sep 17, 2020

Conversation

xabbuh
Copy link
Contributor

@xabbuh xabbuh commented Sep 8, 2020

No description provided.

@xabbuh xabbuh mentioned this pull request Sep 8, 2020
Closed
@xabbuh
Copy link
Contributor Author

xabbuh commented Sep 8, 2020

The ContextFactoryTest currently fails on PHP 8 due to php/php-src@7a3dcc3 (see also phpDocumentor/ReflectionDocBlock#248).

@jaapio jaapio merged commit f598aec into phpDocumentor:1.x Sep 17, 2020
@jaapio
Copy link
Member

jaapio commented Sep 17, 2020

Thanks for this contribution 👍

I merged your PR and improved the implementation a bit

@xabbuh xabbuh deleted the php8-namespace-tokens branch September 18, 2020 07:54
@xabbuh
Copy link
Contributor Author

xabbuh commented Sep 18, 2020

Thank you @jaapio!

@TamasSzigeti TamasSzigeti mentioned this pull request Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xabbuh @jaapio