Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Retain login form data across admin data updates #38

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

benloh
Copy link

@benloh benloh commented Sep 13, 2024

Fixes #23

Fixes bug where login form input field will reset if there are admin data updates, e.g. add new prop.

To Test

  1. On the first computer on a login screen and enter some text (without hitting Enter)
  2. On second computer, login and create a new model
  3. On the second computer, add a new prop/mech/outcome.
  4. As soon as the prop is added, the login screen on the first computer refreshes. The login should be retained and not cleared.

…23

Fixes bug where login form input field will reset if there are admin data updates, e.g. add new prop
@benloh benloh requested a review from Sakelun September 13, 2024 23:02
@benloh
Copy link
Author

benloh commented Sep 13, 2024

@Sakelun I think this should address the login reset problem. Please let me know if it doesn't.
Please assign back to me to merge.

@benloh benloh merged commit 147e277 into dev-next Sep 24, 2024
@benloh benloh deleted the hotfix-retain-login branch September 24, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant