Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Relax excessive ESLint configuration rules #23

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

dsriseah
Copy link

@dsriseah dsriseah commented Jun 18, 2024

Ben reports that it's difficult to work with all the extra errors reported in the component files as he does MUI conversion.

This PR partially addresses #21, updating the ESLint configuration to relax rules that the new prettier/prettier ruleset (which is now a superset prettier/react) introduced. ESLint now has more recommendations than in 2018, and I have relaxed some of them to "warn" level, while others are off. For a complete list, check the .estlintrc.js file.

NOTE: I left in several rules that do reveal issues that should be addressed and are pretty easy to do.

ESLINTRC TEST

  • instead of pulling the branch, go to dev-sri/build-config-fixes/.eslintrc.js to grab the .eslintrc.js file
  • in your current working repo, paste the .eslintrc.js file next to where your .eslintrc.json file is
  • rename .eslintrc.json to old-eslintrc.json
  • quit visual studio code, then reopen
  • report if the eslintrc flagging looks any better than before
  • look at the output for ESLintrc and see if there are errors.

NOTE: ESLint only checks on open files, so you'll have to click around to see.

OTHER CHANGES

This PR also includes updates to .vscode folder default snippets and settings, affecting FormatOnSave settings using a more "global" approach and removing the LiveShare extension as a recommended extension

@dsriseah dsriseah requested a review from benloh June 18, 2024 17:20
Copy link

@benloh benloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! This'll go a long way towards focusing on the key lint fixes.

@benloh benloh merged commit eb51cbd into dev Jun 18, 2024
benloh added a commit that referenced this pull request Sep 13, 2024
…23

Fixes bug where login form input field will reset if there are admin data updates, e.g. add new prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants