Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranged through an array to make social-follow.html more efficient #376

Closed
wants to merge 3 commits into from

Conversation

zjrohrbach
Copy link

@zjrohrbach zjrohrbach commented Dec 23, 2020

not sure if this is helpful, but I made the social-follow.html more succinct by ranging through all of the repetitive code.

This could probably be improved by making sure the title and aria-label attributes are correctly capitalized for each link. I used humanize to try to achieve this, but it does not split 'Stack Overflow' into two words or correctly capitalize 'LinkedIn.'

@budparr
Copy link
Member

budparr commented Dec 28, 2020

Thanks for this. We'll review right after the holiday.

fixed most of the capitalization issues by making use of `lower` hugo command.  The only outstanding problem is that Stack Overflow will render as `StackOverflow` (one word).  This could probably be fixed with a simple `if` statement
@zjrohrbach
Copy link
Author

I think this most recent commit fixes most of the capitalization issues. The only remaining problem is that 'Stack Overflow' still renders as one word instead of two.

Fixed small error
@regisphilibert regisphilibert added the Waiting Waiting on a response or other action label Oct 1, 2021
@regisphilibert
Copy link
Member

regisphilibert commented Dec 2, 2021

Thanks @zjrohrbach and sorry for not addressing your PR sooner as it did make a lot of sense. I just merged #422 which refactors the whole social logic of the theme! Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting Waiting on a response or other action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants