Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Social API #422

Closed
regisphilibert opened this issue Jun 14, 2021 · 1 comment · Fixed by #425
Closed

Improve Social API #422

regisphilibert opened this issue Jun 14, 2021 · 1 comment · Fixed by #425

Comments

@regisphilibert
Copy link
Member

regisphilibert commented Jun 14, 2021

Users need to be able to customize/add social service with icons. We'll cater for some built in and direct users how to add new ones.
The new UX will handle better ordering, more customization, easy addition of future customization.

We'll make this retrocompatible.

UX

Old UX:

# config/_default/params.yaml
description: Something lorem ipsum
twitter: https://twitter.com/GoHugoIO
github: https://github.com/GoHugoIO

New UX:

# config/_default/params.yaml
ananke_socials:
- name: twitter
   url: https://twitter.com/GoHugoIO
   color: #1da1f2
- name: github
   url: https://github.com/GoHugoIO
   color: #6cc644

Adding user's own icon

User will be directed to add an svg file matching the service's name at /assets/ananke/icons/

Ex: If user wants to add twitch:

ananke_socials:
- name: twitch
   url: https://twitch.com/GoHugoIO

User will drop its svg as /assets/ananke/icons/twitch.svg

Adding built in icons/service

This will also improve the way contributor can submit new built in services by complementing a single source file for service name and color and add one (consistent formating) svg.

This should take care or help contributors handling #420 #419 #418 and more...

@budparr
Copy link
Member

budparr commented Oct 1, 2021

I guess we need the ananke_...?

regisphilibert added a commit that referenced this issue Dec 2, 2021
* Start of work

* Refactor social service logic

Update README

Fixes #422

* Add URL to contributors instuctions

* Add tiktok
Remicck pushed a commit to Remicck/gohugo-theme-ananke that referenced this issue Mar 7, 2022
* Start of work

* Refactor social service logic

Update README

Fixes theNewDynamic#422

* Add URL to contributors instuctions

* Add tiktok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants