Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kb38 via supported #2224

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Add kb38 via supported #2224

merged 5 commits into from
Apr 8, 2024

Conversation

DOIO2022
Copy link
Contributor

@DOIO2022 DOIO2022 commented Apr 3, 2024

Description

Add kb38 via supported

QMK Pull Request

qmk/qmk_firmware#19650

qmk/qmk_firmware#21268

qmk/qmk_firmware#21704

qmk/qmk_firmware#22811

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

dunk2k
dunk2k suggested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formating

v3/doio/kb38/kb38-01.json Outdated Show resolved Hide resolved
v3/doio/kb38/kb38-01.json Outdated Show resolved Hide resolved
DOIO2022 and others added 2 commits April 5, 2024 19:10
@DOIO2022 @dunk2k
Update v3/doio/kb38/kb38-01.json
9c7682c 
Co-authored-by: Duncan Sutherland <[email protected]>
@DOIO2022 @dunk2k
Update v3/doio/kb38/kb38-01.json
65a9776 
Co-authored-by: Duncan Sutherland <[email protected]>
dunk2k
dunk2k suggested changes Apr 5, 2024
View reviewed changes
v3/doio/kb38/kb38-01.json Outdated Show resolved Hide resolved
@DOIO2022 @dunk2k
Update v3/doio/kb38/kb38-01.json
e528b4f 
Co-authored-by: Duncan Sutherland <[email protected]>
Cipulot
Cipulot requested changes Apr 8, 2024
View reviewed changes
v3/doio/kb38/kb38-01.json Outdated Show resolved Hide resolved
@Cipulot Cipulot merged commit 50401d1 into the-via:master Apr 8, 2024
2 checks passed
@Cipulot Cipulot mentioned this pull request Apr 25, 2024
Merged
7 tasks
@weswigham weswigham mentioned this pull request Apr 25, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cipulot Cipulot Cipulot approved these changes

@weswigham weswigham weswigham left review comments

@dunk2k dunk2k dunk2k requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DOIO2022 @weswigham @Cipulot @dunk2k