Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate RGB Matrix config to info.json - D #22811

Merged
merged 3 commits into from
Jan 7, 2024
Merged

Migrate RGB Matrix config to info.json - D #22811

merged 3 commits into from
Jan 7, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 2, 2024 •
edited
Loading

Description

Migrates RGB Matrix config.h content now that there is sufficient coverage available.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as ready for review January 4, 2024 07:01
@zvecr zvecr merged commit 6e3cc56 into qmk:develop Jan 7, 2024
3 of 4 checks passed
@zvecr zvecr deleted the dd_rgb_matrix5 branch January 7, 2024 13:36
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@zvecr @mechlovin
Migrate RGB Matrix config to info.json - D (qmk#22811)
cb95e79
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@zvecr @mechlovin
Migrate RGB Matrix config to info.json - D (qmk#22811)
866d1f1
@DOIO2022 DOIO2022 mentioned this pull request Apr 3, 2024
Merged
7 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Migrate RGB Matrix config to info.json - D (qmk#22811)
f949dec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark