Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoder-in-matrix "hack" removal #1873

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

adophoxia
Copy link
Contributor

Description

Updates the JSONs that uses the action_exec hack for fake encoders to instead use encoder mapping (e0, e1, etc. for the encoder button).

The updating process, which involved:

  • Removing fake encoder rotation keys
  • Having to move around some keys to be accurate to where they are located physically
  • Editing the layout indexes to be able to add encoder options on keys that already had existing indexes attached
  • etc.

Note: I only did this for boards in the v3 directory since it'd be pointless to do the same for boards in src if they're eventually flashed with v3 firmware. There may be some boards that I might've missed, or wasn't included in #20389.

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant