Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoder-in-matrix "hack" removal notification #155

Open
tzarc opened this issue Apr 9, 2023 · 1 comment
Open

Encoder-in-matrix "hack" removal notification #155

tzarc opened this issue Apr 9, 2023 · 1 comment

Comments

@tzarc
Copy link

tzarc commented Apr 9, 2023

Just a heads-up, as per the deprecation policy QMK is going to be removing the "encoder-in-keymatrix" hacks that older boards used pre-encodermap. These are already causing issues with maintenance during refactoring and cleanup, and put simply, have no future within the codebase.

Encoder mapping has been in for several breaking changes cycles now, and new board submissions have already transitioned across to using it.

We'll be doing so on the develop branch shortly after the current breaking change cycle completes, which is intended to occur 2023-05-28. This will give VIA 3 months after that date to handle the conversion of in-matrix encoders to encoder map.

Raising this issue so that you guys have visibility and an appropriate lead time to make whatever changes VIA requires on your end.

@adophoxia
Copy link

Decided to raise a draft up a PR over in the-via/keyboards repo pertaining to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants