Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to 1up product line #1708

Closed
wants to merge 7 commits into from
Closed

updates to 1up product line #1708

wants to merge 7 commits into from

Conversation

ziptyze
Copy link
Contributor

@ziptyze ziptyze commented Feb 21, 2023 •
edited
Loading

update to pi40 to work with new layout option

Description

QMK Pull Request

qmk/qmk_firmware#19903

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@wilba
Copy link
Contributor

wilba commented Feb 24, 2023

Why are you deleting V2 definitions?

@ziptyze
Copy link
Contributor Author

ziptyze commented Feb 27, 2023

I wasn't intentionally, I must have deleted them locally accidentally somehow. All I really need is the pi40 and pi60 jsons

@wilba
Copy link
Contributor

wilba commented Feb 27, 2023

You'll need to rebase or merge with the latest files and put back the v2 files.

@lesshonor lesshonor mentioned this pull request Feb 28, 2023
Merged
6 tasks
@ziptyze ziptyze closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziptyze @wilba