Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to pi40 #19903

Closed
wants to merge 4 commits into from
Closed

Update to pi40 #19903

wants to merge 4 commits into from

Conversation

ziptyze
Copy link
Contributor

@ziptyze ziptyze commented Feb 21, 2023

Updates to pi40

Description

Updated pi40 to include v1.1 of the pcb which allows for grid and mit layouts

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 21, 2023
@ziptyze ziptyze mentioned this pull request Feb 21, 2023
Closed
6 tasks
zvecr
zvecr reviewed Feb 21, 2023
View reviewed changes
keyboards/1upkeyboards/pi40/rules.mk
@@ -1,26 +1,4 @@
# MCU name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs a DEFAULT_FOLDER rule or it has to be removed (otherwise it will create invalid build targets).

@ziptyze ziptyze mentioned this pull request Mar 1, 2023
Merged
7 tasks
@ziptyze ziptyze closed this Mar 8, 2023
@waffle87 waffle87 mentioned this pull request Mar 8, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ziptyze @drashna @zvecr