Allow players to use ISO A2 codes to guess the country #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some country data
This is because when WB_A2 or WB_A3 is "-99" (which it is for a large amount of countries), it would allow a player to guess more than one country at once.
|
Hey @QwertyHJKL1234, this is an interesting possible update to the game, but I don't think it's necessary. I even worry that it's very easy to get these codes mixed up, and so players might accidentally guess the wrong country, which will mess with their scores/streaks. I feel like we would be inviting in a bit of chaos. If someone else thinks that this would be a welcome addition to the game, please let me know! Otherwise I'm going to close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personally, I get annoyed when I'm playing Globle, and it doesn't accept the country code. I don't know if many people get annoyed by this but I decided to fix it, so yeah... Might help fix #15
TL:DR With this PR you can now use codes like GB for Great Britain, or CN for China, or DK for Denmark, etc. Might help fix #15
I have edited some of the country data, because some countries had their ISO_A2 code as "-99" which I have fixed using the ISO website.
(also it says two contributors, they are both me lol)