Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mispellings #15

Closed
jaoxford opened this issue Feb 8, 2022 · 6 comments
Closed

Mispellings #15

jaoxford opened this issue Feb 8, 2022 · 6 comments

Comments

@jaoxford
Copy link

jaoxford commented Feb 8, 2022

I think this game is great! Thanks for creating it.

As for the actual issue:
I think slight mispellings should be accepted.

For example I had typed kyrzgystan and the correct spelling is kyrgyzstan. Could there be some way of checking for countries that are slightly misspelt, or some kind of hinting mechanism?

@IanDLacy
Copy link

IanDLacy commented Feb 8, 2022

I think someone on another issue suggested some kind of suggestion|completion mechanism similar to the kind of 'automatic drop down' things you see around. I don't think misspellings should be accepted, but I think some mechanism as described would be a nice convenience feature.

@waldyrious
Copy link

There could be a list of known aliases, for example based on Wikipedia redirects to the country article (excluding redirects to sections), which would have the benefit of including alternative valid names, besides common mispellings.

@jaoxford
Copy link
Author

There could be a list of known aliases, for example based on Wikipedia redirects to the country article (excluding redirects to sections), which would have the benefit of including alternative valid names, besides common mispellings.

Something along these lines is a good idea.

@zerdip
Copy link

zerdip commented Feb 25, 2022

Awesome game.
Greenland is invalid?
England is invalid? (Shows as UK)

@cornzz
Copy link

cornzz commented Mar 27, 2022

Awesome game. Greenland is invalid? England is invalid? (Shows as UK)

Greenland is not really its own country, its part of Denkmark.
England is a country but doesn't have its own government and is usually just regarded as part of the UK, just like the other parts of UK.
https://www.sporcle.com/blog/2013/01/what-is-a-country/

Also, the title of this issue is ironic

@the-abe-train
Copy link
Owner

Closing this thread to move the discussion of spelling corrections to PR #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants