Skip to content

Commit

Permalink
Update code_smells_56773_reviewlog.txt
Browse files Browse the repository at this point in the history
The task associated with the reviewed code smell detailed in the reviewlog is "Code Smell JabRef#3".
  • Loading branch information
miguel-real-miei authored Nov 23, 2021
1 parent 0b8d6c6 commit 5cba97d
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Team Meber 56971, João Vieira:
Team Member 56971, João Vieira:
Regarding Long Parameter List:
"Yes I agree that parameter lists of these 3 constructors are too long, I also think both your proposed fixes will probably be necesserary in some cases. For example in the GuiPreferences.java constructor, even if we bundle the position and size parameters into its own class, we will still have a paramters list of size 6, which is still too long."

Team Member 55677, Miguel Real:
Regarding Comments/Dead Code:
"It seems the developers taking care of this feature may have forgotten about the commented code, which is an unfortunate but common problem in larger projects. I agree with the problem itself and the proposed solution, and mark this task as Complete."

0 comments on commit 5cba97d

Please sign in to comment.