-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some example new Dutch translations via the GitHub web page. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
added a commit
that referenced
this pull request
Mar 15, 2014
Some example new Dutch translations via the GitHub web page.
1 task
johannes-manner
added a commit
to johannes-manner/jabref
that referenced
this pull request
Feb 6, 2018
Fixed the issue "DOI: encoded URLs should be supported". New divider within the DOI % is supported.
5 tasks
Siedlerchr
added a commit
that referenced
this pull request
Feb 7, 2018
* upstream/master: (47 commits) Fix Google Scholar fetcher Use english for all LCID mappings #1851 remove import preferences test mock import and convert to junit5 fix #3693 (#3702) Fix space leads to jump in entry editor (#3699) Fix #3669 Extract creation of the contents of FileAnnotationTabController Fix changelog Fix NPE Remove unnecessary file use processbuilder for calling external apps Fix color highlight of odd linked files Fixes #2964 Fix koppor issues #3 Allow spaces in DOIs Remove irrelevant log messages during XMP reading Adapt log4j configuration for cleaner junit tests #3511 Eclipse Django style #3655 Better code style for chained methods Update build.gradle ...
calixtus
pushed a commit
that referenced
this pull request
Aug 18, 2020
calixtus
pushed a commit
that referenced
this pull request
Aug 23, 2020
miguel-real-miei
added a commit
to the-Kob/SE2122_55677_56773__56971_57066_58625
that referenced
this pull request
Nov 23, 2021
The task associated with the reviewed code smell detailed in the reviewlog is "Code Smell JabRef#3".
miguel-real-miei
added a commit
to the-Kob/SE2122_55677_56773__56971_57066_58625
that referenced
this pull request
Dec 4, 2021
The metrics discussed were Martin Packaging Metrics. This commit is in respect to task: `Metrics Set JabRef#3`
Siedlerchr
added a commit
that referenced
this pull request
Oct 30, 2022
…ubgroups (#9286) * Closes issue #1, opens issues #3, #4 * Adjusted removeGroupNoSubgroups to keep consistent with other removeGroup__ methods * Update context menu each time it is opened, to reflect any changes that may have been made to subgroups Adjusted removeSubgroups.setOnAction to be consistent with other action events * Update CHANGELOG.md * Removed "Remove subgroups" and "Sort subgroups" options when no subgroups present * Removed context submenu addition from event listener * Fixed JavaDoc for removeGroupNoSubgroups * Added remove text to language file * Fixed popup when deleting group with no subgroups Co-authored-by: Christoph <[email protected]>
Siedlerchr
pushed a commit
that referenced
this pull request
Mar 27, 2023
(Feat): #1 Added test for storage of proxy preferences
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
* Adds feature CleanupJob for removing non-existent files (#2) * feat: RemoveLinksToNotExistentFiles.java * feat: added option to cleanup entries * feat: improved cleanup entry dialogue * Test: implements test for linked files which exist Implementation of a test which calls the cleanup functionality of RemoveLinksToNotExistentFiles with a entry that is linked to an existing file. The test makes sure that no changes are made since the linked file exists. * Refactor: refactored test to match the standard of the project Removed the JavaDoc comment from the test, since other tests in the project don't have JavaDoc:s. Also removed test from the name of the test function, as it seems that the standard way of naming tests is to not have test in the testfunctions name. * Refactor: removed system.out.print() Removed an print from the tests. * fix: non english character deleted * Docs: Added information about changes Added information about the changes made for solving issue#10929 to the CHANGES.md file. --------- * Fix: Removes unused imports and solves other errors Removes unused imports and solves the error of language keys that were not in the english laguage file. * Fix: Removes empty line and solves other issues Removes an empty line where 2 empty lines appear in after each other. Also adds brackets to URL and removes an key which is not in the english language file and was missed in the last commit. * Docs: Removes technicality from changelog Removes technical details for the change made in changelog and also follows the suggestion for removing the space and brackets between the link and the issue. * test: enhanced RemoveLinksToNotExistentFilesTest (#3) * test: enhanced RemoveLinksToNotExistentFilesTest * test: add real content * test: change structure * test: added expectedChanges * test: added a third test to RemoveLinksToNotExistentFilesTest * refactor: removed unnecessary toString * style: removed a whitespace * refactor: checkstyle formatting. formatted files according to checkstyle plugin. --------- * Resolve request changes (#4) * test: enhanced RemoveLinksToNotExistentFilesTest * test: add real content * test: change structure * test: added expectedChanges * test: added a third test to RemoveLinksToNotExistentFilesTest * refactor: removed unnecessary toString * style: removed a whitespace * refactor: checkstyle formatting. formatted files according to checkstyle plugin. * refactor: replaced .get(0) with .getFirst() for first accessing element of List. Changed was required from ./gradlew rewriteDryRun --------- * Resolve more request changes and warnings (#5) * Reverse the condition and the content in RemoveLinksToNotExistentFiles Resolves comment "Reverse the condition and the content. Reason: You have BOTH (true and false) cases covered. The true case should normally come first." * Fix: Store bibFolder.resolve("test.bib") in a variable * Refactor: Rename variable fileFolder to originalFileFolder and remove comment. * Refactor: Rename defaultFileFolder to newFileFolder * Refactor: Fix indentation in RemoveLinksToNotExistentFilesTest * Refactor: Replaced Arrays.asList() with List.of() * Refactor: Replaced Arrays.asList() with List.of() * Refactor: Change to use java.nio for file deletion. * Refactor: Move comment to line above. * Refactor: Added "PDF" as third argument to LinkedFile for OnlineLink files * Refactor: Removed unused variables in RemoveLinksToNotExistentFiles * Refactor: Throw IOException in RemoveLinksToNotExistentFilesTest functions * Refactor: Tests assert using List.of() in RemoveLinksToNotExistentFilesTest * Refactor: Corrected Arguments for LinkedFile in RemoveLinksToNotExistentFilesTest * Refactor: Class fields into local variables This refactor fixed 3 warnings. * docs: updated docs to remove merge conflict --------- Co-authored-by: karlsb <[email protected]> Co-authored-by: burcukilic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.