Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing E2E tests using headless Chrome #8005

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fixing E2E tests using headless Chrome #8005

merged 2 commits into from
Dec 18, 2024

Conversation

pedro-stanaka
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

GiedriusS and others added 2 commits December 18, 2024 12:32
@GiedriusS
.github: run e2e tests on newer ubuntu
8e4eb42 
I cannot reproduce chromedp panics locally so trying to see if a newer
Ubuntu version would help.

Signed-off-by: Giedrius Statkevičius <[email protected]>
@pedro-stanaka
Forcing headless and making sure we can run it before creating the co…
e2cb509 
…ntext for testing

Signed-off-by: Pedro Tanaka <[email protected]>
@pedro-stanaka pedro-stanaka marked this pull request as ready for review December 18, 2024 10:55
@pedro-stanaka pedro-stanaka mentioned this pull request Dec 18, 2024
Open
@fpetkovski fpetkovski merged commit b881f6c into thanos-io:main Dec 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaHoffmann MichaHoffmann MichaHoffmann approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pedro-stanaka @MichaHoffmann @fpetkovski @GiedriusS