Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receive: fix maxBufferedResponses channel size to avoid deadlock #7978

Merged
merged 3 commits into from
Dec 18, 2024
Merged

receive: fix maxBufferedResponses channel size to avoid deadlock #7978

merged 3 commits into from
Dec 18, 2024

Conversation

rvichery
Copy link
Contributor

@rvichery rvichery commented Dec 10, 2024 •
edited
Loading

Fixes #7977

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Fix the size of the maxBufferedResponses channel to take into account that localWrites may contain more than one tenant when using split-tenant-label-name feature

Verification

@rvichery rvichery force-pushed the fix-7977-remote-write-hangs-with-split-label branch from 4a20358 to d9f592c Compare December 10, 2024 17:22
GiedriusS
GiedriusS previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiedriusS GiedriusS enabled auto-merge (squash) December 11, 2024 08:52
@GiedriusS GiedriusS disabled auto-merge December 11, 2024 08:52
@GiedriusS
Copy link
Member

Could you also update the docs https://github.com/thanos-io/thanos/actions/runs/12261380236/job/34208260569?pr=7978? You'll need to update the sed command in docs/components/receive.md because the line numbers changed

@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 12, 2024
@rvichery rvichery force-pushed the fix-7977-remote-write-hangs-with-split-label branch from b14301d to 057fc42 Compare December 12, 2024 00:13
@rvichery rvichery force-pushed the fix-7977-remote-write-hangs-with-split-label branch from 057fc42 to 49d2e6b Compare December 12, 2024 17:03
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 12, 2024
@rvichery rvichery requested a review from GiedriusS December 12, 2024 17:56
@rvichery
Copy link
Contributor Author

@GiedriusS I have addressed the docs feedback. Could you please review the PR?

@GiedriusS GiedriusS merged commit 1b58ed1 into thanos-io:main Dec 18, 2024
22 checks passed
@pedro-stanaka pedro-stanaka mentioned this pull request Dec 18, 2024
Merged
2 tasks
nicolastakashi pushed a commit to nicolastakashi/thanos that referenced this pull request Jan 9, 2025
@rvichery @nicolastakashi
receive: fix maxBufferedResponses channel size to avoid deadlock (tha…
da9c136 
…nos-io#7978)

* Fix maxBufferedResponses channel size to avoid deadlock

Fixes thanos-io#7977

Signed-off-by: Remi Vichery <[email protected]>

* Add changelog entry

Signed-off-by: Remi Vichery <[email protected]>

* adjust line numbers in docs/components/receive.md to match updated code

Signed-off-by: Remi Vichery <[email protected]>

---------

Signed-off-by: Remi Vichery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

receive: remote write handler hangs when using "split-tenant-label-name"
2 participants
@rvichery @GiedriusS