Add --disable-admin-operations flag in Compactor UI and Bucket UI

[harsh-ps-2003]

Signed-off-by: Harsh Pratap Singh [email protected]
Fixes #5390

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

This PR adds a flag, named --disable-admin-operations, to the Compactor UI and Bucket Web UI to decide whether to disable the corresponding buttons Mark Deletion and Mark No Compaction in the UI as they are admin-level operations. It also restricts the API usage for both of them.

Verification

It was tested locally.
The UI test:

The API test:

❯ curl -X POST -d "id=_ulid&action=DELETION" http://localhost:8080/api/v1/blocks/mark
{"status":"error","errorType":"bad_data","error":"Admin operations are disabled"}
❯ curl -X POST -d "id=_ulid&action=DELETION" http://localhost:10922/api/v1/blocks/mark
{"status":"error","errorType":"bad_data","error":"Admin operations are disabled"}

cc @yeya24 @GiedriusS @saswatamcode

[harsh-ps-2003]

If everything goes okay with this PR, I will add the changelog. Sorry for messing up a lot of times and thanks for the patience. Also how to fix this Docs CI failing!? @saswatamcode @yeya24

[saswatamcode]

@harsh-ps-2003 you don't need to raise a new PR every time after review. you can push commits to address feedback. 🙂
Also, you can run make doc and commit to fix docs CI

[saswatamcode]

Thanks!
Generally LGTM mod some small nits. 🙂

Let's try to address comments here instead of opening new PR!

[saswatamcode]

Let's make description a bit clearer.

Suggested change

	cmd.Flag("disable-admin-operations", "Restrict access to Block Mark deletion and no compaction").Default("false").BoolVar(&cc.disableAdminOperations)
	cmd.Flag("disable-admin-operations", "Disable UI/API admin operations like marking blocks for deletion and no compaction.").Default("false").BoolVar(&cc.disableAdminOperations)

[saswatamcode]

ditto

Suggested change

	cmd.Flag("disable-admin-operations", "Restrict access to Block Mark deletion and no compaction").Default("false").BoolVar(&tbc.disableAdminOperations)
	cmd.Flag("disable-admin-operations", "Disable UI/API admin operations like marking blocks for deletion and no compaction.").Default("false").BoolVar(&tbc.disableAdminOperations)

[saswatamcode]

We can probably render both buttons, under a single conditional?

[saswatamcode]

Let's actually call this in BlocksContent and pass it to BlocksDetails as a prop, that way we won't be calling this every time we open a block detail page. This also won't change from block to block.

[harsh-ps-2003]

Thanks for the review and sorry for the closed PRs @saswatamcode

[harsh-ps-2003]

@saswatamcode @yeya24 @GiedriusS when I did make docs, it gave me an error

>> cleaning up white noise
sed: 1: "./CODE_OF_CONDUCT.md": invalid command code .
make[1]: *** [white-noise-cleanup] Error 1
make: *** [docs] Error 2

as I am on Mac OS. The invalid sed command is happening as on macOS; the sed command requires an empty string argument after the -i option when doing in-place editing, while on Linux, this argument is optional. I have locally made changes to the cleanup-white-noise script to work on both Mac and Linux systems. And this was the reason the Docs CI was failing.
After fixing this when I do make docs I don't get any errors, but when I do make check-docs I get the errors! How should I go about it? make docs is not able to fix these error!! Sorry!