Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to disable block mark deletion and mark no compaction from bucket UI #5390

Closed
yeya24 opened this issue May 27, 2022 · 6 comments · Fixed by #6646
Closed

Provide option to disable block mark deletion and mark no compaction from bucket UI #5390

yeya24 opened this issue May 27, 2022 · 6 comments · Fixed by #6646

Comments

@yeya24
Copy link
Contributor

yeya24 commented May 27, 2022

In Prometheus, admin level functionalities like delete series are not provided through UI.
But in Thanos, now it is supported to mark deletion and mark no compaction from bucket UI. This is an admin-level operation and requires admin permissions. Some users might not want to expose those functionalities from bucket UI to their users.

We can have an option to disable those functionalities from UI or make those features not enabled by default.

@stale
Copy link

stale bot commented Jul 31, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jul 31, 2022
@yeya24
Copy link
Contributor Author

yeya24 commented Jul 31, 2022

Still valid

@stale stale bot removed the stale label Jul 31, 2022
@stale
Copy link

stale bot commented Oct 1, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Oct 1, 2022
@stale stale bot removed the stale label Dec 20, 2022
@yeya24
Copy link
Contributor Author

yeya24 commented Dec 21, 2022

@Vaani-pathariya https://thanos.io/tip/thanos/quick-tutorial.md/ is a great resource to start.
This issue doesn't require much knowledge about Thanos. Some UI/backend knowledge is good enough.

@harsh-ps-2003
Copy link
Contributor

harsh-ps-2003 commented Aug 6, 2023

@yeya24 Do you want a checkbox to disable block mark deletion and mark no compaction or to disable them by default?
I far as I can understand if it's disabled by default, admins cant enable this using flags as I didn't find any flag like this and users also won't be able to access it. If there is a checkbox for it to be enabled, I currently don't know if there is a separate UI setup for admins and users so that admins can make it available to users if they want through the UI.
If nobody else is working on the issue I can give it a try!!
Screenshot 2023-08-06 at 10 50 47 AM

@yeya24
Copy link
Contributor Author

yeya24 commented Aug 6, 2023

@harsh-ps-2003 I think we want a new flag to disable this functionality. When the flag is set, users shouldn't be able to add markers in the UI.
I don't think we need to add any checkbox in the UI itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment