Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Traces sampler env var follow-up PR #6359

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shayyxi
Copy link
Contributor

@shayyxi shayyxi commented May 11, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@shayyxi
Copy link
Contributor Author

shayyxi commented May 11, 2023

This is a follow-up PR to address the review comments in the following merged PR:
#6306

@shayyxi shayyxi changed the title Traces sampler env var follow-up PR [DRAFT] Traces sampler env var follow-up PR May 11, 2023
@matej-g matej-g marked this pull request as draft May 12, 2023 10:04
@stale
Copy link

stale bot commented Jun 18, 2023

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 18, 2023
@shayyxi
Copy link
Contributor Author

shayyxi commented Jun 18, 2023

I will resume work on it from next week.

@stale stale bot removed the stale label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant