Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing: Add missing sampler types #7230

Closed
matej-g opened this issue Mar 25, 2024 · 1 comment · Fixed by #7231
Closed

Tracing: Add missing sampler types #7230

matej-g opened this issue Mar 25, 2024 · 1 comment · Fixed by #7231
Labels
difficulty: easy good first issue help wanted

Comments

@matej-g
Copy link
Collaborator

matej-g commented Mar 25, 2024

Is your proposal related to a problem?

We are still missing some additions to our tracing setup and we should support more samplers out of the box. The initial work has been done here #6306, but we're still missing some adjustments.

Describe the solution you'd like

See the suggestions here: #6306 (review)

Describe alternatives you've considered

N/A

Additional context

There was a draft PR that began work (#6359) on this but so far it hasn't moved
@NeerajNagure
Copy link
Contributor

Hi,I would like to work on this.Can you please assign it to me?

@NeerajNagure NeerajNagure mentioned this issue Mar 25, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tracing: added missing sampler types
2 participants
@matej-g @NeerajNagure