Mixin: Follow naming convention for bucketReplicate #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yeya24
reviewed
Nov 12, 2021
| absent(up{job=~".*thanos-bucket-replicate.*"} == 1) | ||
| for: 5m | ||
| labels: | ||
| severity: critical |
There was a problem hiding this comment.
Yes, there is another generator that handles the generation of these alerts. This was redundant.
saswatamcode
previously approved these changes
Nov 13, 2021
There was a problem hiding this comment.
Thanks for this! 💫
Docs check seems to fail due to examples/alerts/alerts.yaml not being updated. I think running make examples-clean and then make docs will fix this.
Maybe this is a Makefile issue due to examples/alerts/alerts.yaml not being phony. 🤔
added 3 commits
November 15, 2021 14:08
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
jessicalins
force-pushed
the
fix-naming-convention-bucket-replicate
branch
from
54341bf to
87a5a94
Compare
kakkoyun
requested changes
Nov 16, 2021
| absent(up{job=~".*thanos-bucket-replicate.*"} == 1) | ||
| for: 5m | ||
| labels: | ||
| severity: critical |
There was a problem hiding this comment.
Yes, there is another generator that handles the generation of these alerts. This was redundant.
added 4 commits
November 16, 2021 14:59
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
kakkoyun
reviewed
Nov 18, 2021
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
auto-merge was automatically disabled
November 18, 2021 16:47
Head branch was pushed to by a user without write access
yeya24
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jéssica Lins [email protected]
Changes
As discussed here and to follow up on this TODO:
thanos/mixin/config.libsonnet
Lines 56 to 57 in b1c7483
I just renamed
bucket_replicate->bucketReplicateto keep the naming convention consistent.Verification
After the changes I've ran
make examplesto regenerate the files.