-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixin: Add Query Frontend grafana dashboard #4856
Conversation
43b0360
to
a46357e
Compare
mixin/config.libsonnet
Outdated
@@ -28,6 +28,10 @@ | |||
selector: 'job=~".*thanos-query.*"', | |||
title: '%(prefix)sQuery' % $.dashboard.prefix, | |||
}, | |||
query_frontend+:: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that we would like to fix the naming convention to e.g. queryFrontend
(this TODO: https://github.com/thanos-io/thanos/blob/main/mixin/config.libsonnet#L52)
I've tried at first to use it like that, but when running make examples
and when it tries to generate the json file, I get:
/home/jessica/go/bin/jsonnet-v0.17.0 -J mixin/vendor -m examples/dashboards mixin/dashboards.jsonnet
RUNTIME ERROR: Field does not exist: query_frontend
Does someone have an idea of what it could be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to replicate this error by changing everything to queryFrontend
except the query_frontend.json
in this line. Once changed to queryFrontend.json
, make examples
runs successfully!
I think this is due to how examples are generated by dashboards.jsonnet
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, that solved the problem!
since I'm already touching those files, should I also update https://github.com/thanos-io/thanos/blob/main/mixin/config.libsonnet#L52 to this convention in this PR? or better in another one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be better to do the update in a separate PR! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, added here: #4859
a46357e
to
1485a62
Compare
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
Signed-off-by: Jéssica Lins <[email protected]>
157822c
to
dc01f84
Compare
Signed-off-by: Jéssica Lins <[email protected]>
dc01f84
to
ff226e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
Let's merge and iterate, looks good! Thanks 💪🏽
Changes
Hey! 👋
I've added a grafana dashboard for the Query Frontend component. I used the Query/Store dashboards as base.
Here is a screenshot of how it currently looks like:
I'm not sure if all metrics that are interesting are represented in the dashboard, but I've tried to add some basic ones (RED metrics/caching/resources)
Verification
I've ran
make examples
to generate thequery_frontend.json
file and I've imported it to Grafana to get an idea how it looks like.