UI: Fix react UI bug with series going on and off #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onprem
previously approved these changes
Jan 21, 2021
|
Thanks for this PR :) @Namanl2001 would you mind rebasing? With that done, we could merge |
Namanl2001
force-pushed
the
react-ui-bug
branch
from
64e8278
to
03afcaa
Compare
|
Resolved all conflicts. Ready to Merge. Thanks |
|
Ah sorry, looks like we still managed to get a conflict after all this. Can you rebase this once again, please? |
onprem
previously approved these changes
Apr 10, 2021
onprem
changed the title
Signed-off-by: Namanl2001 <[email protected]>
Signed-off-by: Namanl2001 <[email protected]>
Signed-off-by: Namanl2001 <[email protected]>
Signed-off-by: Namanl2001 <[email protected]>
auto-merge was automatically disabled
April 11, 2021 18:07
Head branch was pushed to by a user without write access
Namanl2001
force-pushed
the
react-ui-bug
branch
from
870bec7
to
fdabc38
Compare
Rebased this PR 3rd time. Let's see if it can be merged this time 😄 . @onprem |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Namanl2001 [email protected]
Fixes a subissue
Fix react UI bug with series going on and offin #3541.